New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent's visibility trumps inherited 'show' option #12228

Merged
merged 5 commits into from Mar 13, 2018

Conversation

Projects
None yet
4 participants
@ckerr
Member

ckerr commented Mar 12, 2018

The fix works but needs a spec.

Fixes #12125.

@ckerr ckerr requested a review from electron/reviewers as a code owner Mar 12, 2018

@ckerr ckerr changed the title from [WIP] Parent's visibility trumps inherited 'show' option to Parent's visibility trumps inherited 'show' option Mar 13, 2018

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Mar 13, 2018

Member

/trop run backport

Member

MarshallOfSound commented Mar 13, 2018

/trop run backport

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Mar 13, 2018

This PR has not been merged yet, and cannot be backported.

trop bot commented Mar 13, 2018

This PR has not been merged yet, and cannot be backported.

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Mar 13, 2018

Member

Armed with only the help of three other highly-paid engineers of @codebytere, @MarshallOfSound, and @alexeykuzmin I was able to write two paragraphs of ES6 Electron code today. 🥈

In all seriousness: even though this PR is trivial I appreciate the feedback on writing more idiomatic ES6. Thanks for the reviews. 👍

Member

ckerr commented Mar 13, 2018

Armed with only the help of three other highly-paid engineers of @codebytere, @MarshallOfSound, and @alexeykuzmin I was able to write two paragraphs of ES6 Electron code today. 🥈

In all seriousness: even though this PR is trivial I appreciate the feedback on writing more idiomatic ES6. Thanks for the reviews. 👍

@MarshallOfSound MarshallOfSound merged commit 8e07e74 into master Mar 13, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details
@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Mar 13, 2018

We have automatically backported this PR to "1-8-x", please check out #12243

trop bot commented Mar 13, 2018

We have automatically backported this PR to "1-8-x", please check out #12243

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Mar 13, 2018

We have automatically backported this PR to "2-0-x", please check out #12244

trop bot commented Mar 13, 2018

We have automatically backported this PR to "2-0-x", please check out #12244

@trop trop bot added merged/2-0-x and removed target/2-0-x labels Mar 13, 2018

@codebytere codebytere deleted the fix-window-open-not-showing branch Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment