New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport - Fix menubar toggle alt key detection on focus #12235

Merged
merged 1 commit into from Mar 13, 2018

Conversation

Projects
None yet
3 participants
@trop-devel

trop-devel bot commented Mar 13, 2018

Backport of #12167

See that PR for details.

Fix menubar toggle alt key detection on focus
Reset alt keypress flag on window blur so switching window via
Alt+* window manager keybindings can't incedentally trigger
annoying menubar toggles

@trop-devel trop-devel bot requested a review from electron/reviewers as a code owner Mar 13, 2018

@electron electron deleted a comment from welcome bot Mar 13, 2018

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Mar 13, 2018

Member

macOS/pr-head failing with serviceWorker flake

Member

ckerr commented Mar 13, 2018

macOS/pr-head failing with serviceWorker flake

@ckerr ckerr merged commit af4dfcf into electron:2-0-x Mar 13, 2018

8 of 10 checks passed

jenkins: macOS/pr-head This commit cannot be built
Details
ci/circleci: electron-linux-x64 CircleCI is running your tests
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment