New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport - fix: Incorrect warnings in webviews #12236

Merged
merged 2 commits into from Mar 13, 2018

Conversation

Projects
None yet
2 participants
@trop-devel

trop-devel bot commented Mar 13, 2018

Backport of #12234

See that PR for details.

@trop-devel trop-devel bot requested a review from electron/reviewers as a code owner Mar 13, 2018

@trop-devel trop-devel bot added the backport label Mar 13, 2018

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Mar 13, 2018

Member

arm64/pr-head appears to be a flake. Opened an issue at #12237 to track.

Member

ckerr commented Mar 13, 2018

arm64/pr-head appears to be a flake. Opened an issue at #12237 to track.

@ckerr ckerr merged commit 515fbb6 into electron:2-0-x Mar 13, 2018

9 of 10 checks passed

jenkins: arm64/pr-head This commit cannot be built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: macOS/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment