Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update libcc ref for 2.x #12239

Merged
merged 1 commit into from Mar 13, 2018

Conversation

Projects
None yet
4 participants
@deepak1556
Copy link
Member

deepak1556 commented Mar 13, 2018

Verified locally, its not possible to write a spec in electron as it requires to mimic sqlite to leveldb migration which happens between 1.8.x and 2.x.

Ref electron/libchromiumcontent#476

Fixes #12175

/cc @alespergl

@deepak1556 deepak1556 requested a review from as a code owner Mar 13, 2018

@MarshallOfSound
Copy link
Member

MarshallOfSound left a comment

linux x64 appears to have flaked so 👍

@jkleinsc jkleinsc merged commit c22d53b into 2-0-x Mar 13, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details

@deepak1556 deepak1556 deleted the update-libcc-2.x branch Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.