Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: isolate sw file scheme spec storage with temp partition #12241

Merged
merged 1 commit into from Mar 13, 2018

Conversation

Projects
None yet
4 participants
@deepak1556
Copy link
Member

deepak1556 commented Mar 13, 2018

Fixes #12173

@deepak1556 deepak1556 requested a review from as a code owner Mar 13, 2018

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

alexeykuzmin commented Mar 13, 2018

@deepak1556 We should probably merge it into the master too )

@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented Mar 13, 2018

We should probably merge it into the master too

This PR should target master and add a label for target/2-0-x

@deepak1556 deepak1556 changed the base branch from 2-0-x to master Mar 13, 2018

@deepak1556 deepak1556 force-pushed the sw-file-scheme-flaky-patch branch from 226778e to c3bcb60 Mar 13, 2018

@deepak1556

This comment has been minimized.

Copy link
Member Author

deepak1556 commented Mar 13, 2018

Done, thanks!

@jkleinsc jkleinsc merged commit 5a81cfb into master Mar 13, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details

@jkleinsc jkleinsc deleted the sw-file-scheme-flaky-patch branch Mar 13, 2018

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Mar 13, 2018

We have automatically backported this PR to "2-0-x", please check out #12247

@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented Mar 15, 2018

/trop run backport

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Mar 15, 2018

The backport process for this PR has been manually initiated, here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Mar 15, 2018

An error occurred while attempting to backport this PR to "1-7-x", you will need to perform this backport manually

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Mar 15, 2018

We have automatically backported this PR to "1-8-x", please check out #12289

@trop trop bot added merged/1-8-x and removed target/1-8-x labels Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.