New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: fix null pointer dereference with getWebPreferences api #12245

Merged
merged 2 commits into from Mar 13, 2018

Conversation

Projects
None yet
3 participants
@deepak1556
Member

deepak1556 commented Mar 13, 2018

Fixes a crash with opening devtools that became evident after #12236

@deepak1556 deepak1556 requested a review from electron/reviewers as a code owner Mar 13, 2018

@deepak1556 deepak1556 requested a review from zcbenz Mar 13, 2018

@ckerr

ckerr approved these changes Mar 13, 2018

@ckerr

This comment has been minimized.

Member

ckerr commented Mar 13, 2018

arm64/pr-head:

not ok 790 chromium feature websockets has user agent
  Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

There is no way this nullptr PR caused this. Approved.

@codebytere codebytere merged commit c846f67 into 2-0-x Mar 13, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details

@deepak1556 deepak1556 deleted the devtools_crash_patch_2_x branch Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment