New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure that `getLastCrashReport()` is actually the last crash report #12253

Merged
merged 6 commits into from Mar 14, 2018

Conversation

Projects
None yet
4 participants
@felixrieseberg
Member

felixrieseberg commented Mar 13, 2018

This PR fixes #11749 by ensuring that getLastCrashReport() actually returns the last crash report (and not just a certain position in the array).

Also: A test that actually calls the method under test 馃槄

felixrieseberg added some commits Mar 13, 2018

@felixrieseberg felixrieseberg requested a review from electron/reviewers as a code owner Mar 13, 2018

@codebytere

LGTM 馃挴 when we merge this we can close the other PR

@ckerr

This PR is short and sweet. LGTM. One nit inline.

Show outdated Hide outdated spec/api-crash-reporter-spec.js
@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Mar 14, 2018

Member

electron-linux-x64:

AssertionError [ERR_ASSERTION]: false == true
    at Context.it (/home/builduser/project/spec/api-crash-reporter-spec.js:266:7)

electron-linux-ia32:

not ok 987 crashReporter module getLastCrashReport correctly returns the most recent report
  AssertionError [ERR_ASSERTION]: false == true
      at Context.it (/var/lib/jenkins/workspace/ron_ARM64_electron_PR-12253-WP3JY47LEEJ2OR6WRBG4W43ZPAXD4YTS3ZGJCPY3GXIOPM3Q5EKQ@2/spec/api-crash-reporter-spec.js:266:7)
      at runCallback (timers.js:763:18)
      at tryOnImmediate (timers.js:734:5)
      at processImmediate (timers.js:716:5)
Member

ckerr commented Mar 14, 2018

electron-linux-x64:

AssertionError [ERR_ASSERTION]: false == true
    at Context.it (/home/builduser/project/spec/api-crash-reporter-spec.js:266:7)

electron-linux-ia32:

not ok 987 crashReporter module getLastCrashReport correctly returns the most recent report
  AssertionError [ERR_ASSERTION]: false == true
      at Context.it (/var/lib/jenkins/workspace/ron_ARM64_electron_PR-12253-WP3JY47LEEJ2OR6WRBG4W43ZPAXD4YTS3ZGJCPY3GXIOPM3Q5EKQ@2/spec/api-crash-reporter-spec.js:266:7)
      at runCallback (timers.js:763:18)
      at tryOnImmediate (timers.js:734:5)
      at processImmediate (timers.js:716:5)

seems legit

@MarshallOfSound MarshallOfSound merged commit e62349c into electron:master Mar 14, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details
@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Mar 14, 2018

An error occurred while attempting to backport this PR to "1-8-x", you will need to perform this backport manually

trop bot commented Mar 14, 2018

An error occurred while attempting to backport this PR to "1-8-x", you will need to perform this backport manually

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Mar 14, 2018

We have automatically backported this PR to "2-0-x", please check out #12255

trop bot commented Mar 14, 2018

We have automatically backported this PR to "2-0-x", please check out #12255

@trop trop bot added merged/2-0-x and removed target/2-0-x labels Mar 14, 2018

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Mar 14, 2018

Member

@felixrieseberg Could you backport this to 1-8-x 馃槃 The bot did 2-0-x for you 馃憤

Member

MarshallOfSound commented Mar 14, 2018

@felixrieseberg Could you backport this to 1-8-x 馃槃 The bot did 2-0-x for you 馃憤

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Mar 14, 2018

Member

@MarshallOfSound IMO assert(reports.length > 1) was still warranted and we're literally in the same TZ so 馃憥 on the dismissal.

Not a blocker though so 炉\(銉)/炉 on this

Member

ckerr commented Mar 14, 2018

@MarshallOfSound IMO assert(reports.length > 1) was still warranted and we're literally in the same TZ so 馃憥 on the dismissal.

Not a blocker though so 炉\(銉)/炉 on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment