New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window open not showing 1 8 x #12261

Merged
merged 6 commits into from Mar 14, 2018

Conversation

Projects
None yet
2 participants
@ckerr
Member

ckerr commented Mar 14, 2018

Similar to what's already landed in master and 2-0-x but with a one-liner change because ES6 spread didn't land in chromium until c60 馃槅

@ckerr ckerr requested a review from MarshallOfSound Mar 14, 2018

@ckerr ckerr requested a review from electron/reviewers as a code owner Mar 14, 2018

@MarshallOfSound MarshallOfSound merged commit 8144e53 into 1-8-x Mar 14, 2018

8 of 9 checks passed

jenkins: arm64/pr-head This commit cannot be built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-mips64el Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ckerr

This comment has been minimized.

Member

ckerr commented Mar 14, 2018

The jenkins: arm64/pr-head failure is a flake, #12237

@ckerr ckerr deleted the fix-window-open-not-showing_1-8-x branch Mar 14, 2018

@release-notifier

This comment has been minimized.

release-notifier bot commented Mar 16, 2018

This PR landed in electron v1.8.4 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment