New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set appropriate defaults for webview options #12272

Merged
merged 2 commits into from Mar 15, 2018

Conversation

Projects
None yet
3 participants
@ckerr
Member

ckerr commented Mar 14, 2018

Ensure that the webview options object has appropriate default values.

Details at https://www.electronjs.org/blog/webview-fix

@ckerr ckerr requested a review from electron/reviewers as a code owner Mar 14, 2018

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Mar 15, 2018

Requires #12289

MarshallOfSound added some commits Mar 8, 2018

@MarshallOfSound MarshallOfSound merged commit ac75e00 into 1-8-x Mar 15, 2018

9 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-mips64el Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details
@trop

This comment has been minimized.

Contributor

trop bot commented Mar 15, 2018

An error occurred while attempting to backport this PR to "1-7-x", you will need to perform this backport manually

@release-notifier

This comment has been minimized.

release-notifier bot commented Mar 16, 2018

This PR landed in electron v1.8.4 🎉

@pakastin

This comment has been minimized.

pakastin commented Mar 22, 2018

Why did you release this as a patch? It broke 3rd party content in our digital signage system 😓

@ckerr

This comment has been minimized.

Member

ckerr commented Mar 22, 2018

@parastin, sorry to hear that! We try to not make incompatible changes in point releases. This time it was necessary as a mitigation for https://electronjs.org/blog/webview-fix

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Mar 22, 2018

@pakastin Can you clarify or provide an example of how this broke existing code. I still clarify this PR as a fix as it simply ensures that the behavior we have in our docs actually happens in all cases. If you could provide an example of what broke it would help a lot 👍

@pakastin

This comment has been minimized.

pakastin commented Mar 22, 2018

I wouldn't want to disclose the details here, but I'll send you an email 🙂

@pakastin

This comment has been minimized.

pakastin commented Mar 22, 2018

Email sent 😉

@pakastin

This comment has been minimized.

pakastin commented Mar 22, 2018

We updated the players already so no worries, I'm just kindly hoping these kind of changes would be at least with minor semver push in the future.. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment