New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document Python TLS requirements #12276

Merged
merged 6 commits into from May 16, 2018

Conversation

Projects
None yet
5 participants
@felixrieseberg
Member

felixrieseberg commented Mar 14, 2018

This PR provides a simple test script that confirms for people whether or not they need to update Python as well as documentation for how to do so.

Just recommending to update Python for all users is a bit of overkill - users on High Sierra are fine even with an older version of Python; Linux users may be fine with whatever version they have, depending on distro and OpenSSL; Windows users are (as far as I can tell) fine no matter what.

So, new script:

$ python ./script/check-tls.py
$ Your Python is using TLS 1.2, which is sufficient for building Electron.

If things don't look good:

$ python ./script/check-tls.py
$ Your system/python combination is using an outdated security protocol and will not
$ be able to compile Electron. Please see ./docs/development/build-instructions-osx.md.

Closes #12079

@felixrieseberg felixrieseberg requested review from electron/docs as code owners Mar 14, 2018

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Mar 15, 2018

Member

@felixrieseberg Can we run this on every bootstrap 👍 Don't see it adding too much time impact to that process and would greatly increase the usage of this helper 😄

Member

MarshallOfSound commented Mar 15, 2018

@felixrieseberg Can we run this on every bootstrap 👍 Don't see it adding too much time impact to that process and would greatly increase the usage of this helper 😄

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Mar 15, 2018

Member

Also yeah, pylint is not your friend 😆

Member

MarshallOfSound commented Mar 15, 2018

Also yeah, pylint is not your friend 😆

@felixrieseberg

This comment has been minimized.

Show comment
Hide comment
@felixrieseberg

felixrieseberg Mar 15, 2018

Member

Solid idea, it's now running on bootstrap (with the correct verbose parameters). Should save some lives 😆

Member

felixrieseberg commented Mar 15, 2018

Solid idea, it's now running on bootstrap (with the correct verbose parameters). Should save some lives 😆

Show outdated Hide outdated script/tls.py
Show outdated Hide outdated script/tls.py
@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Mar 21, 2018

Member

@zeke I fixed the "operation system" typo. Do you have any other Changes Requested still pending in this PR?

Member

ckerr commented Mar 21, 2018

@zeke I fixed the "operation system" typo. Do you have any other Changes Requested still pending in this PR?

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Mar 21, 2018

Member

@felixrieseberg can you rebase this on master to fix the build failures on linux?

Member

codebytere commented Mar 21, 2018

@felixrieseberg can you rebase this on master to fix the build failures on linux?

felixrieseberg and others added some commits Mar 14, 2018

Trivial copyediting
s/operation system/operating system/
@zeke

zeke approved these changes May 16, 2018

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere May 16, 2018

Member

The linting error is appearing on master as well, merging anyway

Member

codebytere commented May 16, 2018

The linting error is appearing on master as well, merging anyway

@codebytere codebytere merged commit e8735cc into master May 16, 2018

3 of 9 checks passed

ci/circleci: electron-linux-arm Your tests failed on CircleCI
Details
ci/circleci: electron-linux-arm64 Your tests failed on CircleCI
Details
ci/circleci: electron-linux-ia32 Your tests failed on CircleCI
Details
ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-osx-x64 Your tests failed on CircleCI
Details
WIP ready for review
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@codebytere codebytere deleted the document-python branch May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment