New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport (1-8-x) - Document BrowserView.{destroy,isDestroyed} #12298

Merged
merged 1 commit into from Mar 15, 2018

Conversation

Projects
None yet
2 participants
@trop
Contributor

trop bot commented Mar 15, 2018

Backport of #12274

See that PR for details.

@trop trop bot requested review from electron/docs as code owners Mar 15, 2018

@trop trop bot added the backport label Mar 15, 2018

@MarshallOfSound MarshallOfSound merged commit c26372c into electron:1-8-x Mar 15, 2018

8 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-mips64el Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
@release-notifier

This comment has been minimized.

release-notifier bot commented Mar 16, 2018

This PR landed in electron v1.8.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment