New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeError: 'dict' object has no attribute 'required' #12307

Merged
merged 1 commit into from Mar 16, 2018

Conversation

Projects
None yet
6 participants
@jkleinsc
Contributor

jkleinsc commented Mar 15, 2018

When I ran the 2.0.0-beta.4 release, the release process failed with the following error:
required = optional_f.required AttributeError: 'dict' object has no attribute 'required'
This PR fixes that error.
It appears that this was caused by @MarshallOfSound's changes in #12217.

(cherry picked from commit 71c3483)

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Mar 15, 2018

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Mar 15, 2018

Member

if only we had some kind of /trop run backport-to master command

Member

ckerr commented Mar 15, 2018

if only we had some kind of /trop run backport-to master command

@ckerr

ckerr approved these changes Mar 15, 2018

LGTM. This also needs to be in master.

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Mar 15, 2018

Member

That macOS/pr-head failure has nothing to do with this PR; reported as potential flake at #12314

Member

ckerr commented Mar 15, 2018

That macOS/pr-head failure has nothing to do with this PR; reported as potential flake at #12314

@ckerr

ckerr approved these changes Mar 15, 2018

@codebytere codebytere merged commit 433aba3 into 2-0-x Mar 16, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details

@codebytere codebytere deleted the fix-attribute-error branch Mar 16, 2018

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Mar 16, 2018

Member

/trop run backport-to master

Member

MarshallOfSound commented Mar 16, 2018

/trop run backport-to master

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Mar 16, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "master" here we go! :D

trop bot commented Mar 16, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "master" here we go! :D

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Mar 16, 2018

Member

/trop run backport-to master

Member

MarshallOfSound commented Mar 16, 2018

/trop run backport-to master

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Mar 16, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "master" here we go! :D

trop bot commented Mar 16, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "master" here we go! :D

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Mar 16, 2018

An error occurred while attempting to backport this PR to "master", you will need to perform this backport manually

trop bot commented Mar 16, 2018

An error occurred while attempting to backport this PR to "master", you will need to perform this backport manually

@MarshallOfSound MarshallOfSound restored the fix-attribute-error branch Mar 16, 2018

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Mar 16, 2018

Member

/trop run backport-to master

Member

MarshallOfSound commented Mar 16, 2018

/trop run backport-to master

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Mar 16, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "master" here we go! :D

trop bot commented Mar 16, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "master" here we go! :D

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Mar 16, 2018

An error occurred while attempting to backport this PR to "master", you will need to perform this backport manually

trop bot commented Mar 16, 2018

An error occurred while attempting to backport this PR to "master", you will need to perform this backport manually

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Mar 16, 2018

Member

Hey @MarshallOfSound can @Trop clean up its old branches?

Member

zeke commented Mar 16, 2018

Hey @MarshallOfSound can @Trop clean up its old branches?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment