New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same delay-load settings in both debug and release #12328

Merged
merged 1 commit into from Mar 17, 2018

Conversation

Projects
None yet
2 participants
@alespergl
Contributor

alespergl commented Mar 16, 2018

Debug and release should use the same delay-load settings to be consistent in behaviour. Right now, for example, the debug build cannot be run on Windows 7 and 8 because it has hard reference on some Windows 10 APIs.

@alespergl alespergl requested a review from electron/reviewers as a code owner Mar 16, 2018

@deepak1556 deepak1556 requested a review from zcbenz Mar 17, 2018

@zcbenz

zcbenz approved these changes Mar 17, 2018

@zcbenz zcbenz merged commit f993888 into master Mar 17, 2018

10 of 11 checks passed

jenkins: macOS/pr-head This commit cannot be built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details

@zcbenz zcbenz deleted the delay_load branch Mar 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment