Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport (2-0-x) - Remove the race condition between new process creation and context release #12361

Merged
merged 2 commits into from Mar 20, 2018

Conversation

Projects
None yet
1 participant
@trop
Copy link
Contributor

trop bot commented Mar 20, 2018

Backport of #12342

See that PR for details.

MarshallOfSound added some commits Mar 18, 2018

Remove the race condition between new process creation and old proces…
…s releasing remote context

Previously there was a race condition where the getId() method would return the new context ID even
though the release was for the old context.  This changes it to send the "initial" context ID with
the release message to ensure there is no race.

@MarshallOfSound MarshallOfSound merged commit fae6167 into electron:2-0-x Mar 20, 2018

9 of 10 checks passed

ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.