New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update libcc submodule reference to electron-2-0-x #12448

Merged
merged 2 commits into from Apr 3, 2018

Conversation

Projects
None yet
3 participants
@ckerr
Member

ckerr commented Mar 27, 2018

Update libcc submodule reference to pick up the new electron-2-0-x changes, e.g. the 2D canvas patch

Haven't PRed one of these before, so here are the steps I used:

git checkout 2-0-x
git pull
cd vendor/libchromiumcontent
git fetch
git checkout electron-2-0-x
cd ../..
git add vendor
git commit

@ckerr ckerr requested a review from codebytere Mar 27, 2018

@ckerr ckerr requested a review from electron/reviewers as a code owner Mar 27, 2018

@ckerr ckerr merged commit 6c00b37 into 2-0-x Apr 3, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details

@ckerr ckerr deleted the 2-0-x_update-libcc branch Apr 3, 2018

@deepak1556 deepak1556 referenced this pull request Jun 25, 2018

Merged

fix: Revert "remove MarkHghMemoryUsage api" #13421

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment