New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport (2-0-x) - update doc for setProgressBar #12454

Merged
merged 2 commits into from Mar 28, 2018

Conversation

Projects
None yet
1 participant
@trop
Contributor

trop bot commented Mar 27, 2018

Backport of #12428

See that PR for details.

Sean Lee and others added some commits Mar 24, 2018

update doc for setProgressBar
The linter was unable to get `paused` as a possible value for `mode`
update doc for setProgressBar
Addressing PR feedback

@trop trop bot requested a review from electron/docs as a code owner Mar 27, 2018

@trop trop bot referenced this pull request Mar 27, 2018

Merged

update doc for setProgressBar #12428

@trop trop bot added the backport label Mar 27, 2018

@MarshallOfSound MarshallOfSound merged commit 14f8a2a into electron:2-0-x Mar 28, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details

@electron electron deleted a comment Apr 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment