New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium 66 #12477

Merged
merged 205 commits into from Jun 19, 2018

Conversation

Projects
None yet
@alexeykuzmin
Contributor

alexeykuzmin commented Mar 29, 2018

@alexeykuzmin alexeykuzmin requested a review from electron/reviewers as a code owner Mar 29, 2018

@alexeykuzmin alexeykuzmin referenced this pull request Mar 29, 2018

Merged

Chromium 66 #499

@alexeykuzmin alexeykuzmin requested a review from electron/notifications as a code owner Apr 8, 2018

@alexeykuzmin alexeykuzmin requested a review from electron/printing as a code owner Apr 9, 2018

@alexeykuzmin alexeykuzmin requested a review from electron/docs as a code owner Apr 12, 2018

@ibash

This comment has been minimized.

Show comment
Hide comment
@ibash

ibash Apr 12, 2018

Is it done yet?

ibash commented Apr 12, 2018

Is it done yet?

@Ontopic

This comment has been minimized.

Show comment
Hide comment
@Ontopic

Ontopic Apr 20, 2018

Ahhh, almost there. Thank you guys for your hard work so far.

Not sure if it's helpful, but with previous builds of my local Chromium checkout I saw similar errors: https://chromium-review.googlesource.com/c/chromium/src/+/941901

Ontopic commented Apr 20, 2018

Ahhh, almost there. Thank you guys for your hard work so far.

Not sure if it's helpful, but with previous builds of my local Chromium checkout I saw similar errors: https://chromium-review.googlesource.com/c/chromium/src/+/941901

@skreborn

This comment has been minimized.

Show comment
Hide comment
@skreborn

skreborn Apr 25, 2018

@alexeykuzmin Is there any ETA on this?

So sorry for the mention - a production application I'm working on using Electron really needs support for the Unicode Property Escapes feature that's not supported by version 61, but is available for use in version 66.

skreborn commented Apr 25, 2018

@alexeykuzmin Is there any ETA on this?

So sorry for the mention - a production application I'm working on using Electron really needs support for the Unicode Property Escapes feature that's not supported by version 61, but is available for use in version 66.

@ibash

This comment has been minimized.

Show comment
Hide comment
@ibash

ibash Apr 25, 2018

ibash commented Apr 25, 2018

@alexeykuzmin

This comment has been minimized.

Show comment
Hide comment
@alexeykuzmin

alexeykuzmin Apr 26, 2018

Contributor

@skreborn We are working on this.
We have an estimate internally but don't want to share it because it would look like a promise, and we don't want to make any. @ibash is right =)

Contributor

alexeykuzmin commented Apr 26, 2018

@skreborn We are working on this.
We have an estimate internally but don't want to share it because it would look like a promise, and we don't want to make any. @ibash is right =)

@skreborn

This comment has been minimized.

Show comment
Hide comment
@skreborn

skreborn Apr 26, 2018

@alexeykuzmin Perfectly understandable. When I said "estimate", I really meant an estimate though, even if that's just "anywhere in the next 3 months" - but that's okay. I know that these kinds of things tend to have a backlash when they just happen to be inaccurate for some reason, so I'll just wait patiently and make-do with the current version until this is ready. Thanks for the reply!

skreborn commented Apr 26, 2018

@alexeykuzmin Perfectly understandable. When I said "estimate", I really meant an estimate though, even if that's just "anywhere in the next 3 months" - but that's okay. I know that these kinds of things tend to have a backlash when they just happen to be inaccurate for some reason, so I'll just wait patiently and make-do with the current version until this is ready. Thanks for the reply!

@Ontopic

This comment has been minimized.

Show comment
Hide comment
@Ontopic

Ontopic May 3, 2018

Party time seems close, it's working on my mac

Ontopic commented May 3, 2018

Party time seems close, it's working on my mac

@@ -199,7 +199,6 @@
'libraries': [
# Following libraries are always linked statically.
'<(libchromiumcontent_dir)/libhttp_server.a',
'<(libchromiumcontent_dir)/libdesktop_capture.a',

This comment has been minimized.

@alexeykuzmin

alexeykuzmin May 11, 2018

Contributor

@nitsakh
Then we shouldn't build it in libcc
https://github.com/electron/libchromiumcontent/blob/chromium-upgrade/66/chromiumcontent/BUILD.gn#L98

  static_library("desktop_capture") {
      complete_static_lib = true
      deps = [ "//third_party/webrtc/modules/desktop_capture" ]
  }
@alexeykuzmin

alexeykuzmin May 11, 2018

Contributor

@nitsakh
Then we shouldn't build it in libcc
https://github.com/electron/libchromiumcontent/blob/chromium-upgrade/66/chromiumcontent/BUILD.gn#L98

  static_library("desktop_capture") {
      complete_static_lib = true
      deps = [ "//third_party/webrtc/modules/desktop_capture" ]
  }

This comment has been minimized.

@nitsakh

nitsakh May 11, 2018

Contributor

Right, I am making that change.

@nitsakh

nitsakh May 11, 2018

Contributor

Right, I am making that change.

@NAZMULBABLU

This comment was marked as spam.

Show comment
Hide comment
@NAZMULBABLU

NAZMULBABLU commented May 28, 2018

Ok

@alexeykuzmin alexeykuzmin changed the title from [WiP] Chromium 66 to Chromium 66 Jun 15, 2018

@@ -472,6 +481,33 @@ void AtomBrowserClient::SiteInstanceDeleting(
}
}
std::unique_ptr<net::ClientCertStore> AtomBrowserClient::CreateClientCertStore(

This comment has been minimized.

@miniak

miniak Jun 18, 2018

Contributor
@alexeykuzmin

This comment has been minimized.

Show comment
Hide comment
@alexeykuzmin

alexeykuzmin Jun 18, 2018

Contributor

@electron/docs , @electron/notifications , @electron/printing
Can you please review and approve the PR?

Contributor

alexeykuzmin commented Jun 18, 2018

@electron/docs , @electron/notifications , @electron/printing
Can you please review and approve the PR?

@zeke

zeke approved these changes Jun 18, 2018

@MarshallOfSound MarshallOfSound merged commit bcbcb4c into master Jun 19, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@alexeykuzmin alexeykuzmin deleted the upgrade-to-chromium-66 branch Sep 16, 2018

@deepak1556

This comment has been minimized.

Show comment
Hide comment
@deepak1556

deepak1556 Sep 26, 2018

Member

@MarshallOfSound whats the reasoning behind this change ? I am reenabling a weak ptr dcheck #14816 and there is a misuse here, just want to understand this change before writing the fix for it. Thanks!

Member

deepak1556 commented on 5a28759 Sep 26, 2018

@MarshallOfSound whats the reasoning behind this change ? I am reenabling a weak ptr dcheck #14816 and there is a misuse here, just want to understand this change before writing the fix for it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment