Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport (2-0-x) - Handle in-app-purchase less fatally on non-Darwin #12512

Merged
merged 1 commit into from Apr 3, 2018

Conversation

Projects
None yet
1 participant
@trop
Copy link
Contributor

trop bot commented Apr 2, 2018

Backport of #12511

See that PR for details.

Handle in-app-purchase less fatally on non-Darwin
Right now it throws a new error, but this isn't ideal as there
are cases where everything is mass-required, such as Spectron.
Instead, we should throw an error on non-Darwin environments
only when the IAP methods are invoked.

@trop trop bot requested a review from Apr 2, 2018

@trop trop bot added the backport label Apr 2, 2018

@ckerr ckerr merged commit 33aad6a into electron:2-0-x Apr 3, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.