New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native arm/arm64 mksnapshot for 2-0-x #12524

Merged
merged 2 commits into from Apr 3, 2018

Conversation

Projects
None yet
2 participants
@jkleinsc
Contributor

jkleinsc commented Apr 3, 2018

This backports #12521 to 2-0-x
This PR adds the native arm and arm64 mksnapshot binaries to our releases.

Additionally, every release will now have mksnapshot and chromedriver binaries included in the release assets.

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Apr 3, 2018

@ckerr

ckerr approved these changes Apr 3, 2018

@ckerr ckerr merged commit c6c49b9 into 2-0-x Apr 3, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details

@ckerr ckerr deleted the native-arm-mksnapshot-2-0-x branch Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment