New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor grammatical issue in first-app.md #12542

Merged
merged 1 commit into from Apr 5, 2018

Conversation

Projects
None yet
2 participants
@natsuozawa
Contributor

natsuozawa commented Apr 5, 2018

Fixed a grammatical issue in first-app.md

Line 93: "principals" -> "principles"

Fixed one minor grammatical issue
Line 93: "principals and methods" -> "principles and methods"

@natsuozawa natsuozawa requested a review from electron/docs as a code owner Apr 5, 2018

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Apr 5, 2018

💖 Thanks for opening this pull request! 💖

typing cat

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome bot commented Apr 5, 2018

💖 Thanks for opening this pull request! 💖

typing cat

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@vanessayuenn

This comment has been minimized.

Show comment
Hide comment
@vanessayuenn

vanessayuenn Apr 5, 2018

Contributor

Thanks!

Contributor

vanessayuenn commented Apr 5, 2018

Thanks!

@vanessayuenn vanessayuenn merged commit 4316949 into electron:master Apr 5, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details
@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Apr 5, 2018

Congrats on merging your first pull request! 🎉🎉🎉

welcome bot commented Apr 5, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@natsuozawa natsuozawa deleted the natsuozawa:patch-1 branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment