Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport (2-0-x) - Check for devtools in BrowserWindow.getFocusedWindow() #12554

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

trop bot commented Apr 6, 2018

Backport of #12526

See that PR for details.

@trop trop bot requested a review from as a code owner Apr 6, 2018

@trop trop bot added the backport label Apr 6, 2018

@ckerr

ckerr approved these changes Apr 6, 2018

Copy link
Member

ckerr left a comment

jenkins: macOS/pr-head is failing because our Mac CI is having issues today.

IMO this is safe to merge, if someone will second this please do squash & merge 👍

@codebytere codebytere merged commit 5d8f36c into electron:2-0-x Apr 6, 2018

9 of 10 checks passed

jenkins: macOS/pr-head This commit cannot be built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.