New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sccache option to bootstrap #12582

Merged
merged 4 commits into from Apr 30, 2018

Conversation

Projects
None yet
3 participants
@MarshallOfSound
Member

MarshallOfSound commented Apr 10, 2018

Couldn't see a CC wrapper style option for gyp so we inject the sccache commands directly into the generated ninja files.

Turns out CC_wrapper is case sensitive lol 馃槃

Add sccache option to bootstrap
Couldn't see a CC wrapper style option for gyp so we inject the sccache commands directly into the generated ninja files.

@MarshallOfSound MarshallOfSound requested a review from electron/reviewers as a code owner Apr 10, 2018

@deepak1556

LGTM, thanks!

Show outdated Hide outdated toolchain.gypi
Show outdated Hide outdated script/bootstrap.py
Show outdated Hide outdated script/bootstrap.py
@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound
Member

MarshallOfSound commented Apr 12, 2018

Updated @alexeykuzmin

@MarshallOfSound MarshallOfSound merged commit c1381ac into master Apr 30, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@MarshallOfSound MarshallOfSound deleted the sccache branch Apr 30, 2018

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Apr 30, 2018

An error occurred while attempting to backport this PR to "1-8-x", you will need to perform this backport manually

trop bot commented Apr 30, 2018

An error occurred while attempting to backport this PR to "1-8-x", you will need to perform this backport manually

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Apr 30, 2018

We have automatically backported this PR to "2-0-x", please check out #12753

trop bot commented Apr 30, 2018

We have automatically backported this PR to "2-0-x", please check out #12753

@trop trop bot added merged/2-0-x and removed target/2-0-x labels Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment