Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NativeWindow (Part 5): Add NativeWindow::SetContentView #12584

Merged
merged 7 commits into from Apr 11, 2018

Conversation

Projects
None yet
2 participants
@zcbenz
Copy link
Member

zcbenz commented Apr 10, 2018

Do not pass web_contents to NativeWindow via constructor, instead add a SetContentView method that can take views after the window has been created. This allows us to use arbitrary view as NativeWindow's content view in future.

@zcbenz zcbenz requested a review from as a code owner Apr 10, 2018

@zcbenz zcbenz force-pushed the no-webcontents-in-constructor branch from 4244727 to d706a30 Apr 11, 2018

@zcbenz zcbenz merged commit 558d36c into master Apr 11, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@zcbenz zcbenz deleted the no-webcontents-in-constructor branch Apr 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.