New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NativeWindow (Part 6): Move NativeWindow bindings to api::TopLevelWindow #12596

Merged
merged 9 commits into from Apr 14, 2018

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Apr 11, 2018

This PR adds a new api::TopLevelWindow class that has all the NativeWindow JavaScript bindings, the api::BrowserWindow class now inherits from api::TopLevelWindow.

With this PR, we will be able to create pure native windows from JavaScript without using any WebContents in it.

While this PR is huge, most of it is just moving code from one file to another.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Apr 11, 2018

@zcbenz zcbenz merged commit 858828d into master Apr 14, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@zcbenz zcbenz deleted the toplevel-window branch Apr 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment