Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
add new event to auto-updater #12619
This seems to be a workaround for a before-quit edge case of it being emitted too late when autoupdating, is that correct?
What's the rationale for adding a new wart into the public API, rather than fixing the emission order of before-quit? Is fixing the emission order that tricky?
Marking as "Request changes" because there's not a "Request info" option
Changing the emit order may be possible but it would be a breaking change, and not one I'd be super comfortable doing even with semver. Changing order of events would cause very weird issues in some apps that would make it super hard for devs to figure out IMO.