New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.x] Preload doesn't load in sandboxed render if preload path contains special chars #12643

Merged
merged 1 commit into from Apr 17, 2018

Conversation

Projects
None yet
3 participants
@alexeykuzmin
Contributor

alexeykuzmin commented Apr 17, 2018

Backports #12037.

/cc @juturu, @miniak

Preload doesn't load in sandboxed render if preload path contains spe…
…cial chars (#12037)

* Adding missing headers

* adding ut

* Removing the file path exists check

* fixing test

* exposing window.require in UT

(cherry picked from commit 2f4fd33)

@alexeykuzmin alexeykuzmin requested a review from electron/reviewers as a code owner Apr 17, 2018

@ckerr

ckerr approved these changes Apr 17, 2018

LGTM.

@ckerr ckerr merged commit 597c896 into 2-0-x Apr 17, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ckerr ckerr deleted the backport-2f4fd33 branch Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment