New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libcc on 1-8-x to include two backport fixes. #12645

Merged
merged 1 commit into from Apr 19, 2018

Conversation

Projects
None yet
3 participants

@ajmacd ajmacd requested a review from electron/reviewers as a code owner Apr 17, 2018

@ajmacd

This comment has been minimized.

Contributor

ajmacd commented Apr 17, 2018

It'd be great to get these in the next 1.8.x series release.

@alexeykuzmin

This comment has been minimized.

Contributor

alexeykuzmin commented Apr 17, 2018

@jkleinsc It seems like we don't have prebuilt libcc binaries for the electron-1-8-x branch.
The latest commit in there is d56634abfa9f1068b1cb4788510b4c23b14e8c0a.

@jkleinsc

This comment has been minimized.

Contributor

jkleinsc commented Apr 18, 2018

@alexeykuzmin 1-8-x libcc builds are running now. I'll rerun the CI for this PR once they are done.

@ajmacd

This comment has been minimized.

Contributor

ajmacd commented Apr 19, 2018

Looks like CI is happy now; can we merge this? 🙇

@jkleinsc jkleinsc merged commit 9bb3547 into electron:1-8-x Apr 19, 2018

9 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-mips64el Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment