Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add "app.whenReady()" #12652
In general, I'd rather we use the native promise implementation coming in electron/native-mate#32
I'd like to discuss this before merging if possible as this PR is the first real promise based thing going into Electron and I'd like to set the guidelines / standards on what we want to do here
There is no callback based API for this, so I don't think it is really related to The Promisification.
Will let this one through as you're right, it isn't directly related to the promisification work
That said, once we have native promises I'd probably look to reimplement this one first in native promises (would make a good test bed for sure)