Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable navigating on drag/drop #12655

Merged
merged 2 commits into from Apr 26, 2018

Conversation

Projects
None yet
4 participants
@nornagon
Copy link
Contributor

nornagon commented Apr 18, 2018

Ref #12631

This adds an option to WebPreferences to re-enable the behavior if needed.

This has the potential to be a breaking change for apps that depend on the old default, so it should be included in release notes and marked as such.

@nornagon nornagon requested a review from as a code owner Apr 18, 2018

@nornagon nornagon requested a review from as a code owner Apr 19, 2018

@ckerr

ckerr approved these changes Apr 26, 2018

@ckerr ckerr merged commit 1a64b9f into electron:master Apr 26, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.