New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NativeWindow (Part 8): Prepare work for using views::Widget on macOS #12660

Merged
merged 9 commits into from Apr 20, 2018

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Apr 19, 2018

This PR separates a few classes out of AtomNSWindow, and initializes the ViewsDelegate for macOS.

This PR does not change any existing behavior, it is the preparation for migrating NativeWindowMac to use views::Widget.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Apr 19, 2018

@zcbenz zcbenz merged commit 28b8576 into master Apr 20, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@zcbenz zcbenz deleted the mac-views branch Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment