Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] app.isDefaultProtocolClient is available on Linux now #12674

Merged
merged 1 commit into from Apr 22, 2018

Conversation

Projects
None yet
3 participants
@jwheare
Copy link
Contributor

jwheare commented Apr 20, 2018

This was implemented in #10670. The docs were only partially updated in #10839

@jwheare jwheare requested a review from as a code owner Apr 20, 2018

@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Apr 21, 2018

I went to check the PR to see who did that and completely forgot it was me 🤦‍♀️

this looks great, thanks!

@MarshallOfSound MarshallOfSound merged commit bf2b481 into electron:master Apr 22, 2018

9 of 10 checks passed

ci/circleci: electron-osx-x64 Your tests failed on CircleCI
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.