New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off visual zoom by default #12679

Merged
merged 2 commits into from Apr 26, 2018

Conversation

Projects
None yet
2 participants
@nornagon
Contributor

nornagon commented Apr 20, 2018

Ref #12631

Visual zoom can be re-enabled by webContents.setVisualZoomLevelLimits(1, 3) (see web_preferences.cc for more details on how the defaults are currently set).

@nornagon nornagon requested a review from electron/reviewers as a code owner Apr 20, 2018

@ckerr

ckerr approved these changes Apr 26, 2018

👍

@ckerr ckerr merged commit dd7e0f8 into master Apr 26, 2018

1 of 8 checks passed

ci/circleci: electron-linux-arm CircleCI is running your tests
Details
ci/circleci: electron-linux-arm64 CircleCI is running your tests
Details
ci/circleci: electron-linux-ia32 CircleCI is running your tests
Details
ci/circleci: electron-linux-x64 CircleCI is running your tests
Details
ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
WIP ready for review
Details

@ckerr ckerr deleted the no-visual-zoom branch Apr 26, 2018

sindresorhus added a commit to sindresorhus/electron-util that referenced this pull request Sep 19, 2018

Simplify `.disableZoom()`
`webContents.setVisualZoomLevelLimits(1, 1);` is now the default in Electron: electron/electron#12679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment