New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary step from VS Code debugging instructions #12682

Merged
merged 1 commit into from Apr 23, 2018

Conversation

Projects
None yet
2 participants
@theLMGN
Contributor

theLMGN commented Apr 21, 2018

VS Code automatically executes from the windows object on win32.

Not required.
VS Code automatically executes from the `windows` object on win32.

@theLMGN theLMGN requested a review from electron/docs as a code owner Apr 21, 2018

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Apr 21, 2018

💖 Thanks for opening this pull request! 💖

typing cat

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome bot commented Apr 21, 2018

💖 Thanks for opening this pull request! 💖

typing cat

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@ckerr ckerr changed the title from Not required. to Remove unnecessary step from VS Code debugging instructions Apr 23, 2018

@ckerr

ckerr approved these changes Apr 23, 2018

Thanks for the fix! 👍

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Apr 23, 2018

Member

This CI failure is a flake. The PR only touches the docs

Member

ckerr commented Apr 23, 2018

This CI failure is a flake. The PR only touches the docs

@ckerr ckerr merged commit 975964f into electron:master Apr 23, 2018

9 of 10 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Apr 23, 2018

Congrats on merging your first pull request! 🎉🎉🎉

welcome bot commented Apr 23, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@theLMGN theLMGN deleted the theLMGN:patch-1 branch Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment