New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert to more graceful template structure check #12699

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Member

codebytere commented Apr 24, 2018

Resolves #12698.

Reverts to more graceful check of menu template:

  if (!Array.isArray(template)) {
    throw new TypeError('Invalid template for Menu')
  }

as opposed to:

  if (!(template instanceof Array) {
    throw new TypeError('Invalid template for Menu')
  }

/cc @MarshallOfSound

@codebytere codebytere requested a review from electron/reviewers as a code owner Apr 24, 2018

@codebytere codebytere merged commit 7c4964f into master Apr 24, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Apr 24, 2018

We have automatically backported this PR to "1-8-x", please check out #12702

trop bot commented Apr 24, 2018

We have automatically backported this PR to "1-8-x", please check out #12702

@trop trop bot added merged/1-8-x and removed target/1-8-x labels Apr 24, 2018

@codebytere codebytere deleted the graceful-template-check branch Apr 24, 2018

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Apr 24, 2018

We have automatically backported this PR to "2-0-x", please check out #12703

trop bot commented Apr 24, 2018

We have automatically backported this PR to "2-0-x", please check out #12703

@trop trop bot added merged/2-0-x and removed target/2-0-x labels Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment