New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NativeWindow (Part 10): Share more code between NativeWindow implementations #12716

Merged
merged 5 commits into from Apr 30, 2018

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented Apr 26, 2018

By using views::Widget on all platforms, we can now share more code between NativeWindowMac and NativeWindowViews.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Apr 26, 2018

@zcbenz zcbenz merged commit 51b7322 into master Apr 30, 2018

9 of 10 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details

@zcbenz zcbenz deleted the share-more-window-code branch Apr 30, 2018

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Apr 30, 2018

Contributor

@zcbenz just curious what is the goal for all the window refactoring PRs you are working on in the end?

Contributor

bpasero commented Apr 30, 2018

@zcbenz just curious what is the goal for all the window refactoring PRs you are working on in the end?

@zcbenz

This comment has been minimized.

Show comment
Hide comment
@zcbenz

zcbenz Apr 30, 2018

Contributor

@bpasero Eventually I'll add a set of new APIs that can native UI elements in JavaScript.

Contributor

zcbenz commented Apr 30, 2018

@bpasero Eventually I'll add a set of new APIs that can native UI elements in JavaScript.

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Apr 30, 2018

Contributor

@zcbenz cool 👍

Contributor

bpasero commented Apr 30, 2018

@zcbenz cool 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment