New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add did-frame-navigate event to WebContents, pass http response code to it and did-navigate #12723

Merged
merged 2 commits into from May 1, 2018

Conversation

Projects
None yet
2 participants
@bughit
Contributor

bughit commented Apr 26, 2018

This addresses two issues:

  1. there is no did-navigate equivalent for frames
  2. there is no event on WebContents that can notify of http level frame load failures, did-*-navigate is a good opportunity to pass the frame load http status code.

@bughit bughit requested a review from electron/reviewers as a code owner Apr 26, 2018

@bughit bughit changed the title from add did-frame-navigate event to WebContents, pass http response code to to it and did-navigate to add did-frame-navigate event to WebContents, pass http response code to it and did-navigate Apr 26, 2018

@bughit bughit requested a review from electron/docs as a code owner Apr 29, 2018

@bughit

This comment has been minimized.

Contributor

bughit commented Apr 29, 2018

added docs for this and #12614

Returns `WebFrame` - that has the supplied `routingId`, `null` if not found.
Returns

This comment has been minimized.

@zcbenz

zcbenz Apr 30, 2018

Contributor

Redundant line.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Apr 30, 2018

And do you mind rebasing this on master? We had a new change that does formatting check and it may require modifications for this PR.

@bughit

This comment has been minimized.

Contributor

bughit commented Apr 30, 2018

fixed and rebased

@zcbenz

zcbenz approved these changes May 1, 2018

@zcbenz zcbenz merged commit 55a7f6f into electron:master May 1, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@bughit bughit deleted the bughit:did-frame-navigate branch May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment