New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport (2-0-x) - Fix context menu for sandbox devtools #12731

Merged
merged 1 commit into from May 1, 2018

Conversation

Projects
None yet
3 participants
@trop

trop bot commented Apr 27, 2018

Backport of #11933

See that PR for details.

@trop trop bot requested a review from electron/reviewers as a code owner Apr 27, 2018

@trop trop bot added the backport label Apr 27, 2018

@alexeykuzmin alexeykuzmin requested a review from ckerr Apr 27, 2018

@ckerr

ckerr approved these changes Apr 27, 2018

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Apr 27, 2018

Member

@alexeykuzmin the CI failure looks like a flake; can you confirm?

Member

ckerr commented Apr 27, 2018

@alexeykuzmin the CI failure looks like a flake; can you confirm?

@alexeykuzmin

This comment has been minimized.

Show comment
Hide comment
@alexeykuzmin

alexeykuzmin May 1, 2018

Contributor

@alexeykuzmin the CI failure looks like a flake; can you confirm?

It is definitely a flake. See #12749.
The fix is going to be backported in #12776.

Contributor

alexeykuzmin commented May 1, 2018

@alexeykuzmin the CI failure looks like a flake; can you confirm?

It is definitely a flake. See #12749.
The fix is going to be backported in #12776.

@ckerr ckerr merged commit d0bbf3f into electron:2-0-x May 1, 2018

9 of 10 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment