Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when releasing a script context that never had node injected #12741

Merged
merged 1 commit into from May 2, 2018

Conversation

Projects
None yet
4 participants
@nornagon
Copy link
Contributor

nornagon commented Apr 27, 2018

This was causing a renderer to sometimes crash in the test BrowserWindow module "webPreferences" option nativeWindowOpen option opens window from <iframe> tags. The test wasn't failing because the crash occurred when tearing down the window.

@nornagon nornagon requested a review from as a code owner Apr 27, 2018

@deepak1556
Copy link
Member

deepak1556 left a comment

👍

@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented Apr 28, 2018

@nornagon Can you tag this with the target versions should this be backported to?

@nornagon

This comment has been minimized.

Copy link
Contributor Author

nornagon commented Apr 30, 2018

I'd love to but I have no idea which versions those might be. It looks like 94fce43 was the last commit to touch this area in a meaningful way, which was in March, so probably just 2.x is fine?

@codebytere codebytere merged commit 78ab97a into electron:master May 2, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented May 2, 2018

An error occurred while attempting to backport this PR to "2-0-x", you will need to perform this backport manually

@nornagon nornagon deleted the nornagon:fix-iframe-crash branch May 2, 2018

@nornagon

This comment has been minimized.

Copy link
Contributor Author

nornagon commented May 2, 2018

what was the error, trop. TELL ME

/cc @codebytere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.