New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky security-warnings test #12749

Merged
merged 1 commit into from May 1, 2018

Conversation

Projects
None yet
3 participants
@zcbenz
Contributor

zcbenz commented Apr 30, 2018

security warnings "after each" hook - "after each" hook
/home/builduser/project/spec/security-warnings-spec.js
lessAssertionError [ERR_ASSERTION]: false == true
    at w.webContents.on (/home/builduser/project/spec/security-warnings-spec.js:81:7)
    at CallbacksRegistry.apply (/home/builduser/project/out/D/resources/electron.asar/common/api/callbacks-registry.js:47:25)
    at EventEmitter.ipcRenderer.on (/home/builduser/project/out/D/resources/electron.asar/renderer/api/remote.js:270:21)
    at EventEmitter.emit (events.js:127:13)

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Apr 30, 2018

@zcbenz zcbenz merged commit e00b128 into master May 1, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@zcbenz zcbenz deleted the fix-flaky-security-test branch May 1, 2018

@alexeykuzmin

This comment has been minimized.

Show comment
Hide comment
@alexeykuzmin

alexeykuzmin May 1, 2018

Contributor

/trop run backport-to 2-0-x

Contributor

alexeykuzmin commented May 1, 2018

/trop run backport-to 2-0-x

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot May 1, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "2-0-x" here we go! :D

trop bot commented May 1, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "2-0-x" here we go! :D

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot May 1, 2018

We have automatically backported this PR to "2-0-x", please check out #12776

trop bot commented May 1, 2018

We have automatically backported this PR to "2-0-x", please check out #12776

@trop trop bot added the merged/2-0-x label May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment