New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NativeWindow (Part 11): NativeWindowViews should not be a View #12750

Merged
merged 1 commit into from May 1, 2018

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Apr 30, 2018

Do not make NativeWindowViews inherit from views::View, and move view related code into a new class.

With this PR the NativeWindowViews implement would be more similar to NativeWindowMac, and it also decouples the management of MenuBar from NativeWindowViews.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Apr 30, 2018

@zcbenz zcbenz merged commit c67d1b6 into master May 1, 2018

9 of 10 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details

@zcbenz zcbenz deleted the nativewindowviews-no-view branch May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment