New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code signing tutorial #12767

Merged
merged 4 commits into from May 2, 2018

Conversation

Projects
None yet
3 participants
@zeke
Member

zeke commented May 1, 2018

This PR adds a basic tutorial about code signing: what is is, why you need to do it, and how to get started for macOS and Windows.

@zeke zeke requested review from ckerr, felixrieseberg and sethlu May 1, 2018

@zeke zeke requested a review from electron/docs as a code owner May 1, 2018

@ckerr

ckerr approved these changes May 2, 2018

Looks good. Thanks, Zeke!

@ckerr ckerr merged commit f1c7df8 into master May 2, 2018

1 of 8 checks passed

ci/circleci: electron-linux-arm CircleCI is running your tests
Details
ci/circleci: electron-linux-arm64 CircleCI is running your tests
Details
ci/circleci: electron-linux-ia32 CircleCI is running your tests
Details
ci/circleci: electron-linux-x64 CircleCI is running your tests
Details
ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
WIP ready for review
Details

@ckerr ckerr deleted the code-signing branch May 2, 2018

# Signing Windows builds
See the [Windows Store Guide].

This comment has been minimized.

@MarshallOfSound

MarshallOfSound May 2, 2018

Member

I'm not sure this guide actually covers codesigning applications on Windows that don't go to the store (which is what 99% of people do)

I'll make a PR to follow up to this with some more changes 👍

@MarshallOfSound

MarshallOfSound May 2, 2018

Member

I'm not sure this guide actually covers codesigning applications on Windows that don't go to the store (which is what 99% of people do)

I'll make a PR to follow up to this with some more changes 👍

This comment has been minimized.

@zeke

zeke May 2, 2018

Member

Thank you @MarshallOfSound 👍

@zeke

zeke May 2, 2018

Member

Thank you @MarshallOfSound 👍

This comment has been minimized.

@MarshallOfSound
@MarshallOfSound
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment