New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport (2-0-x) - Fix flaky security-warnings test #12776

Merged
merged 1 commit into from May 1, 2018

Conversation

Projects
None yet
3 participants
@trop

trop bot commented May 1, 2018

Backport of #12749

See that PR for details.

@trop trop bot requested a review from electron/reviewers as a code owner May 1, 2018

@trop trop bot referenced this pull request May 1, 2018

Merged

Fix flaky security-warnings test #12749

@trop trop bot added the backport label May 1, 2018

@ckerr ckerr merged commit 289db66 into electron:2-0-x May 1, 2018

9 of 10 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@alexeykuzmin

This comment has been minimized.

Show comment
Hide comment
@alexeykuzmin

alexeykuzmin May 1, 2018

Contributor

@zcbenz
Got exactly the same test failure here. Do we need to backport any other changes?, or the fix simply doesn't work? )
https://circleci.com/gh/electron/electron/19003

AssertionError [ERR_ASSERTION]: false == true
    at w.webContents.on (/Users/distiller/project/spec/security-warnings-spec.js:80:7)
    at CallbacksRegistry.apply (/Users/distiller/project/out/D/Electron.app/Contents/Resources/electron.asar/common/api/callbacks-registry.js:47:25)
    at EventEmitter.ipcRenderer.on (/Users/distiller/project/out/D/Electron.app/Contents/Resources/electron.asar/renderer/api/remote.js:261:21)
    at emitThree (events.js:136:13)
    at EventEmitter.emit (events.js:217:7)
Contributor

alexeykuzmin commented May 1, 2018

@zcbenz
Got exactly the same test failure here. Do we need to backport any other changes?, or the fix simply doesn't work? )
https://circleci.com/gh/electron/electron/19003

AssertionError [ERR_ASSERTION]: false == true
    at w.webContents.on (/Users/distiller/project/spec/security-warnings-spec.js:80:7)
    at CallbacksRegistry.apply (/Users/distiller/project/out/D/Electron.app/Contents/Resources/electron.asar/common/api/callbacks-registry.js:47:25)
    at EventEmitter.ipcRenderer.on (/Users/distiller/project/out/D/Electron.app/Contents/Resources/electron.asar/renderer/api/remote.js:261:21)
    at emitThree (events.js:136:13)
    at EventEmitter.emit (events.js:217:7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment