Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport (2-0-x) - show file filter name for accessory view of file dialog #12779

Merged
merged 2 commits into from May 2, 2018

Conversation

Projects
None yet
4 participants
@trop
Copy link
Contributor

trop bot commented May 1, 2018

Backport of #11959

See that PR for details.

yuya-oc and others added some commits Feb 19, 2018

Show file filter name for accessory view of file dialog
- Respect filters option of dialog.showOpenDialog() and
  dialog.showSaveDialog(). (#10335)
- Show "All Files" for <input> apart from "accept" attribute. (#11456)

@ckerr ckerr added the semver/minor label May 2, 2018

@ckerr
Copy link
Member

ckerr left a comment

We're adding a new picker, which is great, but it's not a bugfix. Since the 2-0-x branch is only for bugfixes, IMO this makes sense for 3.0.0 (already landed in master 👍) and in 2-1-x if we decide to add more features to the 2 series.

@ckerr

ckerr approved these changes May 2, 2018

Copy link
Member

ckerr left a comment

NVM, I'm an idiot.

@ckerr ckerr removed the semver/minor label May 2, 2018

@ckerr ckerr merged commit d33b71c into electron:2-0-x May 2, 2018

8 of 10 checks passed

ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-osx-x64 Your tests failed on CircleCI
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.