Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More code signing docs #12781

Merged
merged 2 commits into from May 2, 2018

Conversation

Projects
None yet
3 participants
@MarshallOfSound
Copy link
Member

MarshallOfSound commented May 2, 2018

Followup to #12767

@MarshallOfSound MarshallOfSound requested a review from zeke May 2, 2018

@MarshallOfSound MarshallOfSound requested a review from as a code owner May 2, 2018

@MarshallOfSound MarshallOfSound changed the title More code signing More code signing docs May 2, 2018

@zeke

zeke approved these changes May 2, 2018

Copy link
Member

zeke left a comment

A few suggested tweaks. Otherwise LGTM 👍

app, whether the change is introduced accidentally or by malicious code.
created by you.

On macOS the system can detect any change to the app, whether the change is

This comment has been minimized.

@zeke

zeke May 2, 2018

Member

s/the app/the app/

introduced accidentally or by malicious code.

On Windows the system assigns a trust level to your code signing certificate which
if you don't have, or if your trust level is low will cause security dialogs to

This comment has been minimized.

@zeke

zeke May 2, 2018

Member

Suggested rewording:

On Windows the system assigns a trust level to your code signing certificate. If you haven't yet established a trust level or your trust level is low, security dialogs will appear when users start using your application. Your trust level builds over time, so it's better to start code signing as early as possible.

This comment has been minimized.

@zeke

zeke May 2, 2018

Member

☝️ Is there a good page we can link to that explains this in more detail?

This comment has been minimized.

@MarshallOfSound

This comment has been minimized.

@ckerr

ckerr May 2, 2018

Member

Would it make sense to add a link to that in this doc?

@ckerr

ckerr approved these changes May 2, 2018

@zeke zeke merged commit 36c4519 into master May 2, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@zeke zeke deleted the more-code-signing branch May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.