New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update command-line backlist switches (1.8.x) #12807

Merged
merged 2 commits into from May 14, 2018

Conversation

Projects
None yet
4 participants
@ckerr
Member

ckerr commented May 3, 2018

Do a better job of finding edge cases, e.g. network_switch_list.h

NB: This can't be tropped because the list is dependent on the libcc version

update command-line backlist switches
Do a better job of finding edge cases, e.g. network_switch_list.h

**NB: This can't be tropped** because the list is dependent on the libcc version

@ckerr ckerr requested a review from electron/reviewers as a code owner May 3, 2018

@ckerr ckerr changed the title from update command-line backlist switches (1.8.x) to [WIP] update command-line backlist switches (1.8.x) May 3, 2018

@ckerr ckerr changed the title from [WIP] update command-line backlist switches (1.8.x) to update command-line backlist switches (1.8.x) May 3, 2018

// | xargs grep -P --no-filename '"\S+"[);]$' \
// | perl -pe 's|^.*?"(\S+)"[);]$| "$1",|'; \
// | LANG="C" sort | uniq
"/prefetch:1",

This comment has been minimized.

@nornagon

nornagon May 14, 2018

Contributor

These things don't look like the others?

This comment has been minimized.

@ckerr

ckerr May 14, 2018

Member

They do look different, but the slash and colon come straight from src/content/public/common/content_switches.cc among other switches, e.g.:

const char kEnableSpeechDispatcher[] = "enable-speech-dispatcher";
#endif

#if defined(OS_WIN)
// /prefetch:# arguments to use when launching various process types. It has
// been observed that when file reads are consistent for 3 process launches with
// the same /prefetch:# argument, the Windows prefetcher starts issuing reads in
// batch at process launch. Because reads depend on the process type, the
// prefetcher wouldn't be able to observe consistent reads if no /prefetch:#
// arguments were used. Note that the browser process has no /prefetch:#
// argument; as such all other processes must have one in order to avoid
// polluting its profile. Note: # must always be in [1, 8]; otherwise it is
// ignored by the Windows prefetcher.
const char kPrefetchArgumentRenderer[] = "/prefetch:1";
const char kPrefetchArgumentGpu[] = "/prefetch:2";
const char kPrefetchArgumentPpapi[] = "/prefetch:3";
const char kPrefetchArgumentPpapiBroker[] = "/prefetch:4";
"0",
"?",

This comment has been minimized.

@nornagon

nornagon May 14, 2018

Contributor

This also looks weird

This comment has been minimized.

@ckerr

ckerr May 14, 2018

Member

It does.

from src/remoting/host/switches.cc:

const char kProcessTypeSwitchName[] = "type";
const char kQuestionSwitchName[] = "?";
const char kVersionSwitchName[] = "version";
@ckerr

This comment has been minimized.

Member

ckerr commented May 14, 2018

Note on the size of this diff:

  1. The strings are sorted with LANG=C now, so the sort order has changed a little

  2. Lots of args disappeared because they existed in libcc/master when the previous list was generated, but but are not in libcc/electron-1-8-x. For example this is the case for switch "alternative" from ./src/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc -- it was added after electron-1-8-x and so isn't in the upated blocklist

@ckerr ckerr merged commit baa12df into 1-8-x May 14, 2018

9 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-mips64el Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ckerr ckerr deleted the update-blacklist-switches_1-8-x branch May 14, 2018

@dataich

This comment has been minimized.

Contributor

dataich commented May 17, 2018

What vulnerability does this patch fix? Thanks!

juturu pushed a commit that referenced this pull request May 21, 2018

Update command-line blacklist switches
Backport from the upstream Electron
#12807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment