New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better OSR tests #12817

Merged
merged 4 commits into from May 3, 2018

Conversation

Projects
None yet
2 participants
@alexeykuzmin
Contributor

alexeykuzmin commented May 3, 2018

  • add a features. method to determine of the OSR is available
  • skip the tests instead of marking them as passed if the OSR is disabled

@alexeykuzmin alexeykuzmin requested a review from electron/reviewers as a code owner May 3, 2018

@ckerr

ckerr approved these changes May 3, 2018

@ckerr ckerr merged commit 3fd0ec9 into master May 3, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ckerr ckerr deleted the better-osr-tests branch May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment