New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the type information in in-app-purchase.md #12822

Merged
merged 1 commit into from May 3, 2018

Conversation

Projects
None yet
3 participants
@stephanwlee
Contributor

stephanwlee commented May 3, 2018

Manually confirmed the correctness by npm run running create-api-json.

@stephanwlee stephanwlee requested a review from AdrienFery May 3, 2018

@stephanwlee stephanwlee requested a review from electron/docs as a code owner May 3, 2018

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot May 3, 2018

💖 Thanks for opening this pull request! 💖

We use
semantic commit messages
to streamline the release process. Before your pull request can be merged, you
should update your pull request title to start with a semantic prefix,
OR prefix at least one of your commit messages.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome bot commented May 3, 2018

💖 Thanks for opening this pull request! 💖

We use
semantic commit messages
to streamline the release process. Before your pull request can be merged, you
should update your pull request title to start with a semantic prefix,
OR prefix at least one of your commit messages.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

docs: fix the type information in in-app-purchase
Method returns Boolean, Manually confirmed the
correctness by running `npm run create-api-json`.

@zeke zeke merged commit a08b4f7 into electron:master May 3, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot May 3, 2018

Congrats on merging your first pull request! 🎉🎉🎉

welcome bot commented May 3, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot May 3, 2018

We have automatically backported this PR to "2-0-x", please check out #12824

trop bot commented May 3, 2018

We have automatically backported this PR to "2-0-x", please check out #12824

@trop trop bot added merged/2-0-x and removed target/2-0-x labels May 3, 2018

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke May 3, 2018

Member

Is @Trop self-aware now? I thought it had to be summoned with some kind of /trop hey do some stuff command?

Member

zeke commented May 3, 2018

Is @Trop self-aware now? I thought it had to be summoned with some kind of /trop hey do some stuff command?

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound May 4, 2018

Member

Trop will auto run on any PR that is merged with the right labels

Member

MarshallOfSound commented May 4, 2018

Trop will auto run on any PR that is merged with the right labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment