Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible menu items no longer triggering #12825

Merged
merged 1 commit into from May 4, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

codebytere commented May 3, 2018

Resolves #12025.

Change removeExtraSeparators(items) such that it no longer filters out invisible menu separators, preventing their accelerators from working.

/cc @zeke

@codebytere codebytere merged commit f67c625 into master May 4, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@codebytere codebytere deleted the fix-invisible-menuitems branch May 4, 2018

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented May 4, 2018

We have automatically backported this PR to "2-0-x", please check out #12831

@trop trop bot added merged/2-0-x and removed target/2-0-x labels May 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.