New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose events (EventEmitter) to sandboxed renderer #12828

Merged
merged 1 commit into from May 4, 2018

Conversation

Projects
None yet
4 participants
@miniak
Contributor

miniak commented May 4, 2018

The events module containing the EventEmitter class is JavaScript only code, which is safe to be exposed to sandboxed renderers. It's also potentially very useful if the client code needs to inherit the EventEmitter.

@miniak miniak requested a review from electron/reviewers as a code owner May 4, 2018

@tarruda

tarruda approved these changes May 4, 2018

@@ -26,6 +26,7 @@ const preloadModules = new Map([
['child_process', require('child_process')],
['electron', electron],
['fs', fs],
['events', events],

This comment has been minimized.

@alexeykuzmin

alexeykuzmin May 4, 2018

Contributor

Should be added above fs.

This comment has been minimized.

@miniak

miniak May 4, 2018

Contributor

moved

@codebytere codebytere merged commit 48fe013 into master May 4, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@codebytere codebytere deleted the sandboxed-renderer-events branch May 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment