New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove judgmental docs terms #12847

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
6 participants
@codebytere
Member

codebytere commented May 7, 2018

Prompted by this tweet.

This PR removes some judgmental words from docs including 'easy', 'just', 'simply', and similar words which might be unfriendly to developers just entering the source and looking at docs.

@codebytere codebytere requested a review from electron/docs as a code owner May 7, 2018

@jkleinsc

Looks good to me! Great idea @codebytere!

@jkleinsc jkleinsc merged commit c13d1e8 into master May 7, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jkleinsc jkleinsc deleted the friendly-docs branch May 7, 2018

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke May 7, 2018

Member

Good stuff. Did you use a tool to find these?

Member

zeke commented May 7, 2018

Good stuff. Did you use a tool to find these?

@ckerr ckerr referenced this pull request May 7, 2018

Merged

Remove more words #12852

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere May 7, 2018

Member

@zeke i just global searched for combinations and variations of words :)

Member

codebytere commented May 7, 2018

@zeke i just global searched for combinations and variations of words :)

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr May 7, 2018

Member

@zeke grep? 🤣

Member

ckerr commented May 7, 2018

@zeke grep? 🤣

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke May 24, 2018

Member

Finally found the thing I was trying to remember: http://alexjs.com

Member

zeke commented May 24, 2018

Finally found the thing I was trying to remember: http://alexjs.com

@nornagon

This comment has been minimized.

Show comment
Hide comment
@nornagon

nornagon May 24, 2018

Contributor

Ah, the ol' "developed on a macbook" giveaway alex_-_catch_insensitive__inconsiderate_writing

Contributor

nornagon commented May 24, 2018

Ah, the ol' "developed on a macbook" giveaway alex_-_catch_insensitive__inconsiderate_writing

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke
Member

zeke commented May 25, 2018

@nornagon

This comment has been minimized.

Show comment
Hide comment
@nornagon

nornagon May 25, 2018

Contributor

Good idea! Done: wooorm/alex#187

Contributor

nornagon commented May 25, 2018

Good idea! Done: wooorm/alex#187

@zeke zeke referenced this pull request Aug 31, 2018

Merged

docs: Add Electron Fiddle to the readme #14396

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment